New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting provider doesn't work in some languages. #336

Closed
ahmedi2l opened this Issue Jun 13, 2017 · 9 comments

Comments

Projects
None yet
4 participants
@ahmedi2l
Copy link

ahmedi2l commented Jun 13, 2017

Hi,
By testing version 1.2.1 of the software, I notice that deleting a provider doesn't work. It seems to be a bug.

@eheintzmann

This comment has been minimized.

Copy link

eheintzmann commented Jun 14, 2017

Same problem with secretary on 1.2.1 version

@ahmedi2l

This comment has been minimized.

Copy link
Author

ahmedi2l commented Jun 14, 2017

Deleting consumer also doesn't work

@alextselegidis

This comment has been minimized.

Copy link
Owner

alextselegidis commented Jun 14, 2017

Are there any messages in the error logs? Which PHP version are you using?

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Contact me in person!
@eheintzmann

This comment has been minimized.

Copy link

eheintzmann commented Jun 15, 2017

tried with php 7.0.10 and 5.6.25 (on wamp server 3.0.6).

Mysql log (french):
2017-06-15T08:22:15.627672Z 0 [Warning] wampmysqld64: Arrêt forcé de la tâche (thread) 3 utilisateur: 'easyappointments'

@ahmedi2l

This comment has been minimized.

Copy link
Author

ahmedi2l commented Jun 15, 2017

There is no error.
I'm using php version 5.6.30 on debian Jessie

The problem may be related to javascript because when we click on the delete button nothing happens.

@BonjourUnivers

This comment has been minimized.

Copy link

BonjourUnivers commented Jun 15, 2017

solved it, the problem comes from the translation file :
We are FRENCH (this is how i found it, the issue only occurs for french people^^), and the 'cancel' translation exists twice, one of them refers to 'Supprimer' (french for 'delete')
You will notice that in the french version, there is no cancel button, because they are "merging" due to the wrong translation, but only the cancel event is bound, this is how you get a cancel action on the delete button.
So, just delete l91 (it should be $lang['cancel']='Supprimer';) in in the french translation_lang.php file, and the correct translation will allow the buttons to generate properly, and therefore, the events will be bound and the ajax call made.

@ahmedi2l

This comment has been minimized.

Copy link
Author

ahmedi2l commented Jun 15, 2017

Bravo @BonjourUnivers for finding out what was wrong.
It works for me now.
Can you make a pull request?

Thanks

@alextselegidis

This comment has been minimized.

Copy link
Owner

alextselegidis commented Jun 15, 2017

Hey, this happened before!

Is this pull request relevant? #329

I have to change the way translation strings are being used in modals ....

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Contact me in person!

@alextselegidis alextselegidis added the bug label Jun 16, 2017

@alextselegidis

This comment has been minimized.

Copy link
Owner

alextselegidis commented Jun 16, 2017

I corrected the issue in develop branch. It will be released with v1.3.

Commit: fe5341a

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Contact me in person!

@alextselegidis alextselegidis added this to the v1.3.0 milestone Jun 16, 2017

@alextselegidis alextselegidis changed the title Deleting provider doesn't work Deleting provider doesn't work in some languages. Jan 2, 2018

@alextselegidis alextselegidis self-assigned this Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment