Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestion scoped slot #9

Conversation

@Owumaro
Copy link
Contributor

commented Sep 1, 2018

#5

  • replaced the v-html on the list-item components with a prop, to be able to pass it to the scoped slot
  • added a data prop on the list-item component for the scoped slot too
  • added the scoped slot pass down on the main component + list component, however it's not perfect (see code comment)
    It would be way easier with this vuejs PR: vuejs/vue#7765
    Instead I had to do it manually, and met another issue (see vuejs/vue#8305 (comment))
  • added an example in the demo

@alexurquhart alexurquhart merged commit 91418a8 into alexurquhart:Development Sep 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexurquhart

This comment has been minimized.

Copy link
Owner

commented Sep 4, 2018

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.