New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5 #6

Merged

alexvcasillas merged 3 commits into alexvcasillas:master from colshacol:fix/dev-environment

Nov 12, 2018

Collaborator

colshacol commented Nov 12, 2018 •

edited

Fixes #5.

Created workspace shortcuts via npm scripts.

# This:
yarn workspace frontend add -D whatever
# ... can now be done more easily like so:
yarn frontend add -D whatever

Added NODE_ENV declarations.

# So we can designate which environment we are working on.
# Also required for (3) of this list. :)
NODE_ENV='development'
NODE_ENV='production'

Added babel-plugin-dev-expression.

// If NODE_ENV='development', __DEV__ will be true.
__DEV__

Used __DEV__ in init-apollo.js.

Replaced the static isProduction with __DEV__.

Colton Colcleasure added 3 commits

November 11, 2018 20:32


          Added workspace shortcuts, NODE_ENV declarations.

eecfbb9


          Added babel-plugin-dev-expression.


          Fixed development environment issues.

58dfda1

colshacol changed the title ~~Fix/dev environment~~ Fix #5

Owner

alexvcasillas commented Nov 12, 2018

Thanks for this awesome contribution @colshacol :)

alexvcasillas merged commit 906e245 into alexvcasillas:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment