Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix createInstance cloning issue. #5

Merged
merged 1 commit into from Jul 11, 2011

Conversation

Projects
None yet
2 participants
Contributor

Page- commented Jul 11, 2011

It would be great if you could pull this small change, it fixes an issue when cloning the the object returned by createInstance that any calls to matchAll on the cloned object actually run on the original object (which is unintuitive and I assume unintended).

Thanks

Change the matchAll function created within createInstance to use thi…
…s for its references. This fixes an issue where if you clone the returned object and then run matchAll it runs on the original rather than cloned object.

alexwarth added a commit that referenced this pull request Jul 11, 2011

Merge pull request #5 from Page-/master
Fix createInstance cloning issue.

@alexwarth alexwarth merged commit 8a36f45 into alexwarth:master Jul 11, 2011

Owner

alexwarth commented Jul 11, 2011

Makes sense, thanks for the patch!

tristanls added a commit to tristanls/ometa-js-node that referenced this pull request Jul 24, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment