New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the linear-gradient() function to new syntax. Close #73 #77

Merged
merged 1 commit into from Oct 6, 2017

Conversation

Projects
None yet
4 participants
@meteorlxy
Contributor

meteorlxy commented Jul 14, 2017

Update the linear-gradient() function to new syntax. Issue #73.

BTW, why there is no official package on npm?

@alexwolfe

This comment has been minimized.

Show comment
Hide comment
@alexwolfe

alexwolfe Jul 14, 2017

Owner

@roblevintennis mind taking a peak at this one?

Owner

alexwolfe commented Jul 14, 2017

@roblevintennis mind taking a peak at this one?

@roblevintennis

This comment has been minimized.

Show comment
Hide comment
@roblevintennis

roblevintennis Jul 14, 2017

Collaborator

@alexwolfe in terms of staging it or spot checking, I'm not going to have time for a bit .. slammed at work. But the syntax refactor looks correct to me.

Collaborator

roblevintennis commented Jul 14, 2017

@alexwolfe in terms of staging it or spot checking, I'm not going to have time for a bit .. slammed at work. But the syntax refactor looks correct to me.

@alexwolfe

This comment has been minimized.

Show comment
Hide comment
@alexwolfe

alexwolfe Jul 14, 2017

Owner
Owner

alexwolfe commented Jul 14, 2017

@roblevintennis

This comment has been minimized.

Show comment
Hide comment
@roblevintennis

roblevintennis Aug 21, 2017

Collaborator

@alexwolfe I'm in the process of trying to update our app to the buttons-2 branch, and noticed this in our webpack compile (I believe the warning was via autoprefixer). In any event, I changed to bottom and the warnings went away

Collaborator

roblevintennis commented Aug 21, 2017

@alexwolfe I'm in the process of trying to update our app to the buttons-2 branch, and noticed this in our webpack compile (I believe the warning was via autoprefixer). In any event, I changed to bottom and the warnings went away

@alexwolfe

This comment has been minimized.

Show comment
Hide comment
@alexwolfe

alexwolfe Aug 21, 2017

Owner
Owner

alexwolfe commented Aug 21, 2017

@roblevintennis

This comment has been minimized.

Show comment
Hide comment
@roblevintennis

roblevintennis Aug 21, 2017

Collaborator

@alexwolfe and fwiw, I'm now spot checking buttons on pages and their rendering as expected (I think) ... this is probably fine to merge

Collaborator

roblevintennis commented Aug 21, 2017

@alexwolfe and fwiw, I'm now spot checking buttons on pages and their rendering as expected (I think) ... this is probably fine to merge

@alexwolfe

This comment has been minimized.

Show comment
Hide comment
@alexwolfe

alexwolfe Aug 21, 2017

Owner
Owner

alexwolfe commented Aug 21, 2017

@roblevintennis

This comment has been minimized.

Show comment
Hide comment
@roblevintennis

roblevintennis Aug 22, 2017

Collaborator

image

Kinda posting back as I see things lol, sorry, but here's the raised button in the app after changing syntax (using v2 Buttons, but the raised buttons appear to be the same).

Here's console CSS (I manually added raised, so ignore the fact that the adjacent invite buttons are flat 😄

image

I'm not sure which browser has what syntax at this point, but, we use a very conservative autoprefixer:

last 5 versions
Explorer >= 10
Firefox >= 17
Chrome >= 31
Safari >= 5
Opera >= 12

So I'm not sure how helpful the output is ... in any event, it's compiling with no complaints and rendering

Collaborator

roblevintennis commented Aug 22, 2017

image

Kinda posting back as I see things lol, sorry, but here's the raised button in the app after changing syntax (using v2 Buttons, but the raised buttons appear to be the same).

Here's console CSS (I manually added raised, so ignore the fact that the adjacent invite buttons are flat 😄

image

I'm not sure which browser has what syntax at this point, but, we use a very conservative autoprefixer:

last 5 versions
Explorer >= 10
Firefox >= 17
Chrome >= 31
Safari >= 5
Opera >= 12

So I'm not sure how helpful the output is ... in any event, it's compiling with no complaints and rendering

@gwleuverink

This comment has been minimized.

Show comment
Hide comment
@gwleuverink

gwleuverink Oct 6, 2017

Having the same problem here. Any news?
As far as I can see this new syntax fixes the autoprefixer warnings. Haven't come across unexpected behaviour yet. It would be great if this could be merged and released as a minor version.

gwleuverink commented Oct 6, 2017

Having the same problem here. Any news?
As far as I can see this new syntax fixes the autoprefixer warnings. Haven't come across unexpected behaviour yet. It would be great if this could be merged and released as a minor version.

@roblevintennis roblevintennis merged commit 0a91b65 into alexwolfe:master Oct 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@roblevintennis

This comment has been minimized.

Show comment
Hide comment
@roblevintennis

roblevintennis Oct 6, 2017

Collaborator

@gwleuverink sorry, yeah, I just merged this..Alex and I have trouble finding time to maintain. If you don't mind, could you just pull down latest and ensure we didn't break something in a major way? Thanks .. cc / @meteorlxy thanks for PR. If you have a spare moment, your code was merged and I don't have time to verify nothing broke. Thanks in advanced and sorry for the delay!

Collaborator

roblevintennis commented Oct 6, 2017

@gwleuverink sorry, yeah, I just merged this..Alex and I have trouble finding time to maintain. If you don't mind, could you just pull down latest and ensure we didn't break something in a major way? Thanks .. cc / @meteorlxy thanks for PR. If you have a spare moment, your code was merged and I don't have time to verify nothing broke. Thanks in advanced and sorry for the delay!

@gwleuverink

This comment has been minimized.

Show comment
Hide comment
@gwleuverink

gwleuverink Oct 6, 2017

Hi @roblevintennis. Thanks for your quick reply and making time to adress this. I have been running a fork with this fix in a project since this morning and have not noticed any issues with compiling or the buttons themselves. I will swap the repo on monday to confirm this pr works as well.

gwleuverink commented Oct 6, 2017

Hi @roblevintennis. Thanks for your quick reply and making time to adress this. I have been running a fork with this fix in a project since this morning and have not noticed any issues with compiling or the buttons themselves. I will swap the repo on monday to confirm this pr works as well.

@meteorlxy

This comment has been minimized.

Show comment
Hide comment
@meteorlxy

meteorlxy Oct 7, 2017

Contributor

@roblevintennis Never mind, finally merged~
Don't worry, this is a systax update of this css function (see: linear-gradient) and won't break anything. I've been using this PR in my own projects.

Contributor

meteorlxy commented Oct 7, 2017

@roblevintennis Never mind, finally merged~
Don't worry, this is a systax update of this css function (see: linear-gradient) and won't break anything. I've been using this PR in my own projects.

@meteorlxy meteorlxy deleted the meteorlxy:patch-1 branch Oct 7, 2017

@roblevintennis

This comment has been minimized.

Show comment
Hide comment
@roblevintennis

roblevintennis Oct 9, 2017

Collaborator

awesome .. thanks @meteorlxy !

Collaborator

roblevintennis commented Oct 9, 2017

awesome .. thanks @meteorlxy !

@gwleuverink

This comment has been minimized.

Show comment
Hide comment
@gwleuverink

gwleuverink Oct 9, 2017

Yep it works perfectly. Tested it today.

gwleuverink commented Oct 9, 2017

Yep it works perfectly. Tested it today.

@roblevintennis

This comment has been minimized.

Show comment
Hide comment
@roblevintennis

roblevintennis Oct 9, 2017

Collaborator

great thx for confirmation @gwleuverink cc / @alexwolfe .. are we porting these up to the unicorn-ui version buttons 2 version? I sort of lost track of which branch has "buttons 2"

Collaborator

roblevintennis commented Oct 9, 2017

great thx for confirmation @gwleuverink cc / @alexwolfe .. are we porting these up to the unicorn-ui version buttons 2 version? I sort of lost track of which branch has "buttons 2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment