get rid of prototype.js methods to make Riot.js framework agnostic. #1

Closed
bgerrissen opened this Issue Mar 7, 2010 · 5 comments

Projects

None yet

2 participants

@bgerrissen

Currently throws errors in IE due to prototype.js methods not being present.

@browserAutoLoad

Line 55 'stopObserving' should be 'detachEvent'.
Line 63 'pollDoScroll.defer()' should be refactored to 'setTimeout(pollDoScroll, 10)'
Line 72 'observe' should be 'attachEvent'
Line 74 'pollDoScroll.defer()' should be refactored to 'setTimeout(pollDoScroll, 10)'

@bgerrissen

Giving riot.js a trial run and found above bugs ;)

@alexyoung
Owner

It doesn't require Prototype at all

@alexyoung
Owner

Actually, I see what you mean. I can't be bothered to fix it because I don't care about IE.

@alexyoung
Owner

I just realised you put the code in your bug report, so I'll try it out. Thanks!

@alexyoung
Owner

IE might make me grumpy, but bgerrissen helped me fix bugs in my Prototype-derived loading code. Closed by 736733d.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment