update email validation regex to be mostly RFC5322 compliant #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzaganelli
approved these changes
Jul 26, 2021
|
Awesome 👏 |
|
You’re welcome! Thank you for this wonderful plugin!
…On Mon, 26 Jul 2021 at 10:34 pm, Alexandre Zaganelli < ***@***.***> wrote:
Awesome 👏
Thank you @jpizzle34 <https://github.com/jpizzle34>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALU6LVU3OMWODONLMQQOIA3TZVI4BANCNFSM5A75XYWQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current email validation being used succesfully validates isolated email strings, however it can be improved upon to be more RFC5322 compliant. For instance the current regex doesn't allow specifying an email string of the form
Jane Citizen <jane.citizen@example.com>.This pull request updates the regex test to be MOSTLY RFC5322 compliant.
The solution references the accepted answer to the following stack overflow question:
https://stackoverflow.com/questions/201323/how-can-i-validate-an-email-address-using-a-regular-expression?page=1&tab=votes#tab-top