Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Authorise SonarCloud access to Github #65
When we so the SonarCloud scan, we get a warning in SonarCloud saying,
Seems like they have changed the integration, @wnicholson can you please authorise this as the organisation admin?
referenced this issue
Nov 1, 2018
Seems like this has broken pull request scanning as it seems like its not setting up the sonarscanner in the environment after enabling this. @wnicholson, would you mind disabling this for a bit to see if this was definitely the cause?
After a painful process realised that it was nothing to do with this. The tests I did was for internal PRs and they all work, external PRs doesn't work (and that's limitation as per their documentation).
The warning for internal PRs seems to have worked, so let's leave this enabled.
@wnicholson, @badgerwithagun, given this is the case, I guess we'll need to merge PRs from forks in to an internal branch, then do a PR to master from there to get the code scanned. We could do this for changes that might have a significant risk of breaking things than every change so that we just don't create too much work for each change?
I'm closing this now as this is as far as we can go with PR analysis.