New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing shallow clone warning #67

Merged
merged 7 commits into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@venushka
Contributor

venushka commented Nov 1, 2018

Fixes #66 as it was accidentally removed while updating Travis configuration to do branch analysis.

venushka added some commits Nov 1, 2018

Fixing shallow clone warning
Fixes #66 as it was accidentally removed while updating Travis configuration to do branch analysis.
Adding sonar.host.url and removing credentials
Seems like since we enabled SonarCloud integration, its failing to find the host. Also the integration documentation states that the authentication keys are unnecessary, so trying out removing it and building.
Adding back the auth token
Seems like it doesn't work without the auth token, adding it back.
@venushka

This comment has been minimized.

Contributor

venushka commented Nov 1, 2018

@badgerwithagun, this change will fix the shallow clone issue, however the pull request builds are failing since we enabled SonarCloud application in GitHub under #65.

@venushka venushka requested a review from badgerwithagun Nov 1, 2018

@venushka

This comment has been minimized.

Contributor

venushka commented Nov 1, 2018

The build is fine now, as mentioned on #65, we can't enable Sonar analysis for PRs from forks, that's a limitation of the Sonar scanner as per their documentation.

This change should be safe to merge after review now.

@badgerwithagun badgerwithagun merged commit 8690e67 into alfasoftware:master Nov 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment