Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: envsubst must not subst nginx vars #55

Closed
wants to merge 1 commit into from

Conversation

@corneliusweiss
Copy link

corneliusweiss commented Mar 17, 2020

fixes #54

@alfg

This comment has been minimized.

Copy link
Owner

alfg commented Mar 17, 2020

Oh, good catch. I wonder if it's possible to change the replace token so we can still pass in arbitrary environment variables to a mounted nginx.conf without having to update the Dockerfile's CMD.

@alfg

This comment has been minimized.

Copy link
Owner

alfg commented Mar 18, 2020

Can try and test with the suggestion from #54?
#54 (comment)

@alfg

This comment has been minimized.

Copy link
Owner

alfg commented Mar 19, 2020

Fixed as part of 3a6b69a

@alfg alfg closed this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.