Permalink
Commits on Dec 16, 2012
  1. @steveklabnik

    Restored 'Working with Validation Errors'

    Somehow this got lost in my PRs before. I'm going to re-check all the
    guides to make sure this didn't happen again elsewhere.
    steveklabnik committed Dec 16, 2012
Commits on Dec 15, 2012
  1. @jeremy

    Merge pull request #8518 from rwz/inheritable-basic-object

    Properly deprecate AS::BasicObject without breaking subclasses of it
    jeremy committed Dec 15, 2012
  2. @robotex82 @steveklabnik

    Add `ActiveModel::Validations::AbsenceValidator`, a validator to chec…

    …k the absence of attributes.
    
    Add `ActiveModel::Errors#add_on_present` method. Adds error messages to present attributes.
    robotex82 committed with steveklabnik Jul 25, 2012
  3. @rafaelfranca

    Merge pull request #8519 from rubys/master

     Remove blank lines from generated Gemfile
    rafaelfranca committed Dec 15, 2012
  4. @rubys

    Remove blank lines from generated Gemfile

    Introduced by 059bdc3
    rubys committed Dec 15, 2012
  5. @vijaydev
  6. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    Conflicts:
    	actionpack/lib/action_view/helpers/form_helper.rb
    	railties/lib/rails/info_controller.rb
    vijaydev committed Dec 15, 2012
  7. @vijaydev

    copy editing [ci skip]

    vijaydev committed Dec 15, 2012
  8. @vijaydev
  9. @vijaydev
  10. @vijaydev
  11. @vijaydev
  12. @vijaydev

    Revert "Add quotes to Numeric Passwords to force string(MySql)"

    This reverts commit e5f8b2b.
    vijaydev committed Dec 15, 2012
  13. @vijaydev

    Revert "Add quotes to Numeric Passwords to force string(Postgres)"

    This reverts commit 6e72099.
    
    Reason: Feel that this isn't the right place.
    vijaydev committed Dec 15, 2012
  14. @rwz
Commits on Dec 14, 2012
  1. @zbskii @steveklabnik

    Remove unicode character encoding from ActiveSupport::JSON.encode

    The encoding scheme (e.g. ☠ -> "\u2620") was broken for characters
    not in the Basic Multilingual Plane.  It is possible to escape them
    for json using the weird encoding scheme of a twelve-character
    sequence representing the UTF-16 surrogate pair (e.g. '𠜎' ->
    "\u270e\u263a") but this wasn't properly handled in the escaping code.
    Since raw UTF-8 is allowed in json, it was decided to simply pass
    through the raw bytes rather than attempt to escape them.
    zbskii committed with steveklabnik Dec 13, 2012
  2. @carlosantoniodasilva

    Skip binary data with binds test for mysql2, fix build

    Mysql2 doesn't support binds, which means no binds payload is set when
    logging, so the logic to render binary data differently here doesn't work.
    
    Introduced in 99d142a.
    carlosantoniodasilva committed Dec 14, 2012
  3. @carlosantoniodasilva
  4. @tenderlove

    Merge pull request #8514 from mmb/filter_blob

    Do not log the binding values for binary columns.
    tenderlove committed Dec 14, 2012
  5. @steveklabnik

    Revert "Fix failing test in railties"

    This reverts commit 6bdc046.
    
    This has been reverted because rails@8554537
    steveklabnik committed Dec 14, 2012
  6. @steveklabnik

    Revert "Merge pull request #8499 from schneems/schneems/html-route-in…

    …spector"
    
    This reverts commit ae68fc3, reversing
    changes made to 0262a18.
    
    See here: rails#8499 (comment)
    steveklabnik committed Dec 14, 2012
  7. @mmb

    Do not log the binding values for binary columns.

    They tend to be large and not very useful in the log.
    mmb committed Dec 14, 2012
  8. @tenderlove

    remove a cache we do not need

    tenderlove committed Dec 14, 2012
  9. @tenderlove

    Merge pull request #8510 from thedarkone/thread_safety_improvements

    Thread safety improvements
    tenderlove committed Dec 14, 2012
  10. @spastorino
  11. @carlosantoniodasilva

    Merge pull request #8400 from matthewrobertson/has-many-through-count…

    …er-cache
    
    Fix for has_many_through counter_cache bug
    
    Counter caches were not being updated properly when replacing
    has_many_through relationships.
    carlosantoniodasilva committed Dec 14, 2012
  12. @rafaelfranca
  13. @matthewrobertson @matthewrobertson

    Fix for has_many_through counter_cache bug

    This commit fixes reported issue #7630 in which counter
    caches were not being updated properly when replacing
    has_many_through relationships
    matthewrobertson committed with matthewrobertson Dec 2, 2012
  14. @rafaelfranca

    Merge pull request #8497 from acapilleri/conditional_cache

    Removed :if / :unless conditions to fragment cache in favour of *cache_i...
    rafaelfranca committed Dec 14, 2012
  15. @acapilleri

    Removed :if and :unless from fragment cache option in favour of

    cache_if(condition, option, &block) and cache_unless(condition, option, &block).
    
    In the PR #8371 was introduced  conditional options :if and :unless in
    the cache method.
    
        Example:
    
          <%= cache @model, if: some_condition(@model) do %>
            ...
          <%end%>
    
    This is a good feature but *cache_if* and and *cache_unless*
    are more concise and close to the standard of rails view helpers
    (ex: link_to_if and link_to_unless).
    
        Example:
    
          <%= cache_if condition, @model do %>
          ...
          <%end%>
    acapilleri committed Dec 12, 2012
  16. @pixeltrix

    Clear url helper methods when routes are reloaded

    Remove all the old url helper methods when clear! is called on the
    route set because it's possible that some routes have been removed.
    pixeltrix committed Dec 14, 2012
  17. @pixeltrix

    Revert "Clear url helpers when reloading routes"

    This doesn't actually remove old url helper methods as they are
    defined in a different module.
    
    This reverts commit 96bcef9.
    
    Conflicts:
    	actionpack/CHANGELOG.md
    pixeltrix committed Dec 13, 2012
  18. @carlosantoniodasilva

    Fix failing test in railties

    Related to the HTML route inspector changes:
    ae68fc3
    carlosantoniodasilva committed Dec 14, 2012
  19. @thedarkone

    Replace some global Hash usages with the new thread safe cache.

    Summary of the changes:
     * Add thread_safe gem.
     * Use thread safe cache for digestor caching.
     * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation.
     * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache.
     * Use TS::Cache to avoid the synchronisation overhead on listener retrieval.
     * Replace synchronisation with TS::Cache usage.
     * Use a preallocated array for performance/memory reasons.
     * Update the controllers cache to the new AS::Dependencies::ClassCache API.
       The original @controllers cache no longer makes much sense after @tenderlove's
       changes in 7b6bfe8 and f345e23.
     * Use TS::Cache in the connection pool to avoid locking overhead.
     * Use TS::Cache in ConnectionHandler.
    thedarkone committed Dec 13, 2012
  20. @gaurish

    Change method is default since rails 3.1 [ci skip]

    Since Rails 3.1, change method is preferred for writing
    migrations. Updated the example, because that command
    would generate migration with change method.
    gaurish committed Dec 14, 2012