Share archetype does not overlay amps #38

Closed
mindthegab opened this Issue Jul 20, 2014 · 6 comments

Comments

Projects
None yet
1 participant
@mindthegab
Contributor

mindthegab commented Jul 20, 2014

From geis....@gmail.com on December 10, 2009 13:05:22

The DoD5015.2 module is available as two AMPs, one for the Alfresco web
client, one for Share. I would like to apply these with Maven. The
Alfresco extension war archetype handles overlaying AMP dependencies, but
the Share archetype does not. Please add support for this.

Original issue: http://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=38

@mindthegab

This comment has been minimized.

Show comment
Hide comment
@mindthegab

mindthegab Jul 20, 2014

Contributor

From colum...@gmail.com on August 03, 2011 18:08:58

I think this is an important feature for the next major release, so probably release for Alfresco 4.x?

Status: Accepted
Labels: Milestone-NextRelease

Contributor

mindthegab commented Jul 20, 2014

From colum...@gmail.com on August 03, 2011 18:08:58

I think this is an important feature for the next major release, so probably release for Alfresco 4.x?

Status: Accepted
Labels: Milestone-NextRelease

@mindthegab

This comment has been minimized.

Show comment
Hide comment
@mindthegab

mindthegab Jul 20, 2014

Contributor

From colum...@gmail.com on August 03, 2011 18:11:07

Labels: -Milestone-NextRelease Milestone-Release4x

Contributor

mindthegab commented Jul 20, 2014

From colum...@gmail.com on August 03, 2011 18:11:07

Labels: -Milestone-NextRelease Milestone-Release4x

@mindthegab

This comment has been minimized.

Show comment
Hide comment
@mindthegab

mindthegab Jul 20, 2014

Contributor

From mauri...@session.it on April 03, 2012 02:41:07

Marked as enhancement

Labels: -Type-Defect Type-Enhancement

Contributor

mindthegab commented Jul 20, 2014

From mauri...@session.it on April 03, 2012 02:41:07

Marked as enhancement

Labels: -Type-Defect Type-Enhancement

@mindthegab

This comment has been minimized.

Show comment
Hide comment
@mindthegab

mindthegab Jul 20, 2014

Contributor

From mauri...@session.it on April 04, 2012 13:50:02

Patch is attached; please note that the mechanism used to unpack AMP files takes in consideration the first-win mechanism used by default by the war-plugin overlay (read here - https://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=41 )

Tested with one AMP overlay.
Would like to have a peer review to the patch before committing, thanks!

Attachment: Fix_for_issue_#38.patch

Contributor

mindthegab commented Jul 20, 2014

From mauri...@session.it on April 04, 2012 13:50:02

Patch is attached; please note that the mechanism used to unpack AMP files takes in consideration the first-win mechanism used by default by the war-plugin overlay (read here - https://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=41 )

Tested with one AMP overlay.
Would like to have a peer review to the patch before committing, thanks!

Attachment: Fix_for_issue_#38.patch

@mindthegab

This comment has been minimized.

Show comment
Hide comment
@mindthegab

mindthegab Jul 20, 2014

Contributor

From colum...@gmail.com on April 06, 2012 02:48:02

Mau, thanks for the patch.

I think we should wait on a decision on issue #41 before proceeding with this. Obviously it's not the functionality that I am questioning (totally needed) but more the "semantic" of the AMPs.

WDYT?

Blockedon: 41

Contributor

mindthegab commented Jul 20, 2014

From colum...@gmail.com on April 06, 2012 02:48:02

Mau, thanks for the patch.

I think we should wait on a decision on issue #41 before proceeding with this. Obviously it's not the functionality that I am questioning (totally needed) but more the "semantic" of the AMPs.

WDYT?

Blockedon: 41

@mindthegab

This comment has been minimized.

Show comment
Hide comment
@mindthegab

mindthegab Jul 20, 2014

Contributor

From colum...@gmail.com on October 29, 2012 03:49:32

Share AMPs are supported in the new Alfresco Maven Plugin, part of the Maven Alfresco SDK 1.0.

AMPs will be automatically unpacked when depended upon in a Share WAR customization project.

Instead, in order to achieve that in your AMP project, you need to set:

alfresco.client.war=share

in your POM, to allow the SDK to know which WAR you are targeting for overlay.

Marking this as fixed for the Maven Alfresco SDK 1.0.

Status: Fixed
Labels: -Milestone-Release4x Milestone-Release-sdk-1.0.0
Blockedon: -maven-alfresco-archetypes:41 maven-alfresco-archetypes:41

Contributor

mindthegab commented Jul 20, 2014

From colum...@gmail.com on October 29, 2012 03:49:32

Share AMPs are supported in the new Alfresco Maven Plugin, part of the Maven Alfresco SDK 1.0.

AMPs will be automatically unpacked when depended upon in a Share WAR customization project.

Instead, in order to achieve that in your AMP project, you need to set:

alfresco.client.war=share

in your POM, to allow the SDK to know which WAR you are targeting for overlay.

Marking this as fixed for the Maven Alfresco SDK 1.0.

Status: Fixed
Labels: -Milestone-Release4x Milestone-Release-sdk-1.0.0
Blockedon: -maven-alfresco-archetypes:41 maven-alfresco-archetypes:41

@mindthegab mindthegab closed this Jul 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment