Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map CloseNotify to EOF #9

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@FauxFaux
Copy link
Contributor

commented Sep 9, 2019

rustls informs us about a clean EOF by causing an error. Handle this case.

The test does fail for me without the fix, but it's not guaranteed to be a good test long-term, maybe something else should be considered.

@FauxFaux FauxFaux force-pushed the FauxFaux:close_notify branch from a17192e to 580e159 Sep 9, 2019

FauxFaux added a commit to FauxFaux/unsnap that referenced this pull request Sep 9, 2019
ureq hacks
1) pick up this patch: algesten/ureq#9
2) avoid connection pool as closing connections barfs it: algesten/ureq#10
@lolgesten

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

I'm happy with this for now. We can always review how to identify the stream close if/when it changes.

@lolgesten

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

Thank you very much!!!

@lolgesten lolgesten merged commit afa0cf9 into algesten:master Sep 11, 2019

@FauxFaux FauxFaux deleted the FauxFaux:close_notify branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.