New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics-reco): allow creation of clients with their own credentials #1223
Conversation
export type OptionalCredentials<TClientOptions extends Credentials> = Omit< | ||
TClientOptions, | ||
keyof Credentials | ||
> & | ||
Pick<Partial<TClientOptions>, keyof Credentials>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if someone can find a cleaner way to implement this, I'm all ears
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0156372:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think the typing is okay.
see https://github.com/algolia/algoliasearch-client-specs-internal/issues/144
This actually didn't need to change any code, just the types, since they didn't allow appId & apiKey, while they actually are passed along already