New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little tests cleanup #423

Merged
merged 2 commits into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@julienbourdeau
Collaborator

julienbourdeau commented Aug 24, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Need Doc update no

Describe your change

  • Add assertions to avoid the message about Risky tests.
  • Ensure all API key created are deleted (I found 28 pages of API keys in our test app)

Note: Tests are currently failing for community PR because of little bug when checking API key index permissions.

@julienbourdeau julienbourdeau changed the title from Fix/tests to Little tests cleanup Aug 24, 2018

@julienbourdeau

This comment has been minimized.

Collaborator

julienbourdeau commented Oct 10, 2018

I'll merge despite the little red flat about analytics, it will be fixed at the API level, not the client level

@julienbourdeau julienbourdeau merged commit c3de2ed into algolia:master Oct 10, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@julienbourdeau julienbourdeau deleted the julienbourdeau:fix/tests branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment