Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: URL percent encoding #798

Merged
merged 4 commits into from Aug 25, 2022
Merged

fix: URL percent encoding #798

merged 4 commits into from Aug 25, 2022

Conversation

VladislavFitz
Copy link
Contributor

@VladislavFitz VladislavFitz commented Aug 24, 2022 •
edited

Summary

This PR fixes the issues with special characters encoding in the request URLs.

  • Percent encodes / character in the path components
  • Updates the url parameters percent encoding using the approach from the previous major version of the client
  • Percent encodes url parameters names

Fix #797
Fix #789

@VladislavFitz VladislavFitz merged commit b28ebf1 into master Aug 25, 2022
@VladislavFitz VladislavFitz deleted the fix/url-encoding branch November 2, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aallam aallam aallam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index.getObject() does not work with full Shopify ID Facet values with certain characters don't work
2 participants
@VladislavFitz @aallam