Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Expose the exhaustiveFacetsCount flags. #81

Merged
merged 2 commits into from May 19, 2015
Merged

Expose the exhaustiveFacetsCount flags. #81

merged 2 commits into from May 19, 2015

Conversation

redox
Copy link
Contributor

@redox redox commented May 15, 2015

No description provided.

@redox redox changed the title Expose the exhaustiveFacetsCount flags. Ref #80 Expose the exhaustiveFacetsCount flags. May 15, 2015
@bobylito
Copy link
Contributor

Thanks @redox. Is it good for peer review? :)

@bobylito bobylito added this to the 2.0.4 milestone May 18, 2015
@Jerska
Copy link
Member

Jerska commented May 18, 2015

Ok, made the test pass. And the timeouts was definitely not used yet, since we werre calling assignFacetTimeout with parameters in the wrong order. (I think it was my mistake)

So it's a breaking update but of a buggy unused feature I think. ;)

@bobylito
Copy link
Contributor

LGTM thanks guys :)

bobylito added a commit that referenced this pull request May 19, 2015
Fix #80 : Expose the exhaustiveFacetsCount flags.
@bobylito bobylito merged commit 592d111 into master May 19, 2015
@vvo vvo deleted the exhaustive-flag branch May 21, 2015 15:16
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants