Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(circle): update node image #875

Merged
merged 3 commits into from Oct 7, 2021
Merged

ci(circle): update node image #875

merged 3 commits into from Oct 7, 2021

Conversation

@Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Oct 7, 2021

same as algolia/instantsearch.js#4918

@Haroenv Haroenv requested review from , tkrugg (assigned from algolia/frontend-experiences-web) and sarahdayan (assigned from algolia/frontend-experiences-web) and removed request for Oct 7, 2021
@Haroenv Haroenv marked this pull request as draft Oct 7, 2021
@Haroenv Haroenv marked this pull request as ready for review Oct 7, 2021
@@ -101,5 +101,8 @@
},
"peerDependencies": {
"algoliasearch": ">= 3.1 < 5"
},
"resolutions": {
"node-sass": "4.14.1"
Copy link
Contributor Author

@Haroenv Haroenv Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

older versions weren't precompiled for this node version, thus required python, which is no longer included in the docker container

tkrugg
tkrugg approved these changes Oct 7, 2021
@Haroenv Haroenv merged commit 3648463 into develop Oct 7, 2021
5 checks passed
@Haroenv Haroenv deleted the fix/ci branch Oct 7, 2021
Haroenv added a commit that referenced this issue Oct 8, 2021
 * ci(circle): update node image (#875) 3648463
 * feat(facets): when * is present, only send that parameter (#874) fc183ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants