Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SearchParameters): ignore invalid parameters #880

Merged
merged 2 commits into from Oct 19, 2021
Merged

fix(SearchParameters): ignore invalid parameters #880

merged 2 commits into from Oct 19, 2021

Conversation

@Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Oct 15, 2021

These parameters could be used maliciously, so are explicilty not allowed in merge

These parameters could be used maliciously, so are explicilty not allowed in merge
@Haroenv Haroenv requested review from , dhayab (assigned from algolia/frontend-experiences-web) and tkrugg (assigned from algolia/frontend-experiences-web) and removed request for Oct 15, 2021
test/spec/functions/merge.js Show resolved Hide resolved
test/spec/functions/merge.js Outdated Show resolved Hide resolved
test/spec/functions/merge.js Show resolved Hide resolved
test/spec/functions/defaultsPure.js Outdated Show resolved Hide resolved
test/spec/functions/defaultsPure.js Show resolved Hide resolved
@Haroenv Haroenv requested a review from sarahdayan Oct 15, 2021
@Haroenv Haroenv removed request for dhayab and tkrugg Oct 18, 2021
@Haroenv Haroenv merged commit 4ff542b into develop Oct 19, 2021
5 checks passed
@Haroenv Haroenv deleted the fix/prototype branch Oct 19, 2021
Haroenv added a commit that referenced this issue Oct 19, 2021
 * fix(SearchParameters): ignore invalid parameters (#880) 4ff542b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants