From 96ab1c384cd45d7d63db1c2b05dc800d733d45ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Vannicatte?= Date: Thu, 20 Jul 2023 11:07:24 +0200 Subject: [PATCH] fix(javascript): publish script esm (#1787) --- .../package.json | 2 +- .../scripts/publish.ts | 26 ++++--------------- .../tsconfig.script.json | 2 +- 3 files changed, 7 insertions(+), 23 deletions(-) diff --git a/clients/algoliasearch-client-javascript/package.json b/clients/algoliasearch-client-javascript/package.json index 7e662cd903..8cdc143b27 100644 --- a/clients/algoliasearch-client-javascript/package.json +++ b/clients/algoliasearch-client-javascript/package.json @@ -10,7 +10,7 @@ "build:many": "lerna run build --include-dependencies --scope ${0:-'{@algolia/*,algoliasearch}'}", "clean": "lerna run clean --include-dependencies", "release:bump": "lerna version ${0:-patch} --no-changelog --no-git-tag-version --no-push --exact --force-publish --yes", - "release:publish": "ts-node --project tsconfig.script.json scripts/publish.ts", + "release:publish": "ts-node --esm --project tsconfig.script.json scripts/publish.ts", "test:size": "bundlesize" }, "devDependencies": { diff --git a/clients/algoliasearch-client-javascript/scripts/publish.ts b/clients/algoliasearch-client-javascript/scripts/publish.ts index 04a67856f8..0e71f0e75b 100755 --- a/clients/algoliasearch-client-javascript/scripts/publish.ts +++ b/clients/algoliasearch-client-javascript/scripts/publish.ts @@ -1,29 +1,13 @@ -import fsp from 'fs/promises'; -import path from 'path'; - -import execa from 'execa'; +import { execaCommand } from 'execa'; import semver from 'semver'; -async function publish(): Promise { - // Read the local version of `algoliasearch/package.json` - const { version } = JSON.parse( - ( - await fsp.readFile( - path.resolve( - __dirname, - '..', - 'packages', - 'algoliasearch', - 'package.json' - ) - ) - ).toString() - ); +import packageJSON from "../packages/algoliasearch/package.json" assert { type: "json" }; +async function publish(): Promise { // Get tag like `alpha`, `beta`, ... - const tag = semver.prerelease(version)?.[0]; + const tag = semver.prerelease(packageJSON.version)?.[0]; - await execa.command( + await execaCommand( `lerna exec --no-bail -- npm_config_registry=https://registry.npmjs.org/ npm publish --access public ${ tag ? `--tag ${tag}` : '' }`, diff --git a/clients/algoliasearch-client-javascript/tsconfig.script.json b/clients/algoliasearch-client-javascript/tsconfig.script.json index 2c7b284162..dd6b35a341 100644 --- a/clients/algoliasearch-client-javascript/tsconfig.script.json +++ b/clients/algoliasearch-client-javascript/tsconfig.script.json @@ -1,6 +1,6 @@ { "extends": "./tsconfig.json", "compilerOptions": { - "module": "commonjs" + "resolveJsonModule": true } }