Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): attributes no longer required in model instance response #1065

Merged
merged 2 commits into from
Oct 4, 2022
Merged

feat(specs): attributes no longer required in model instance response #1065

merged 2 commits into from
Oct 4, 2022

Conversation

writeens
Copy link
Contributor

@writeens writeens commented Oct 4, 2022 •
edited
Loading

🧭 What and Why

  • Content Attributes are now optional parameters in model instance responses
  • Model Attributes are now optional parameters in model instance responses

Changes included:

  • Remove contentAttributes from list of required parameters for model instance responses
  • Remove modelAttributes from list of required parameters for model instance responses

🧪 Test

  • Tests remain unchanged

@netlify
Copy link

netlify bot commented Oct 4, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit dd96448
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/633c15ce86fe5400091c5199
😎 Deploy Preview https://deploy-preview-1065--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 4, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@writeens writeens changed the title feat(specs): content attributes no longer required in model response feat(specs): update attributes no longer required in model response Oct 4, 2022
@writeens writeens marked this pull request as ready for review October 4, 2022 11:25
@writeens writeens requested a review from a team as a code owner October 4, 2022 11:25
@writeens writeens changed the title feat(specs): update attributes no longer required in model response feat(specs): attributes no longer required in model response Oct 4, 2022
@writeens writeens changed the title feat(specs): attributes no longer required in model response feat(specs): attributes no longer required in model instance response Oct 4, 2022
@millotp millotp merged commit 8151e94 into main Oct 4, 2022
@millotp millotp deleted the feat/update-content-attributes branch October 4, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@bengreenbank bengreenbank bengreenbank approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@writeens @algolia-bot @millotp @bengreenbank