Skip to content

fix(scripts): skip invalid semver [skip-bc] #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2024
Merged

fix(scripts): skip invalid semver [skip-bc] #4284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e2d463
fix(scripts): skip invalid semver
shortcuts Dec 24, 2024
bcc28b5
trigger
shortcuts Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions scripts/release/__tests__/versionsHistory.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,42 @@ describe('no new releases', () => {
});
});

it('skips invalid versions', () => {
const versions = generateLanguageVersionsHistory(
[
'1.2.4 Thu Dec 28 15:48:25 2023 +0000',
'1.1 Thu Dec 28 15:48:25 2023 +0000',
'1.2.5 Tue Jan 2 14:17:11 2024 +0000',
'1.2.6 Tue Jan 2 15:26:06 2024 +0000',
'1.2.7 Thu Jan 4 15:09:11 2024 +0000',
],
{ current: '1.2.7', next: '1.2.7' },
);

expect(versions).toEqual({
'1.2.4': {
releaseDate: '2023-12-28',
slaStatus: 'eligible',
supportStatus: 'eligible',
},
'1.2.5': {
releaseDate: '2024-01-02',
slaStatus: 'eligible',
supportStatus: 'eligible',
},
'1.2.6': {
releaseDate: '2024-01-02',
slaStatus: 'eligible',
supportStatus: 'eligible',
},
'1.2.7': {
releaseDate: '2024-01-04',
slaStatus: 'eligible',
supportStatus: 'eligible',
},
});
});

it('parses version of different minor', () => {
const versions = generateLanguageVersionsHistory(
[
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/versionsHistory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export function generateLanguageVersionsHistory(
}

// we skip any form of pre-releases because they are not part of the VersionsHistory
if (isPreRelease(tagVersion)) {
if (isPreRelease(tagVersion) || !semver.valid(tagVersion)) {
continue;
}

Expand Down