Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(algolia): parse user agents with new search clients #302

Merged
merged 1 commit into from Jan 23, 2020
Merged

fix(algolia): parse user agents with new search clients #302

merged 1 commit into from Jan 23, 2020

Conversation

francoischalifour
Copy link
Member

This fixes #301 by supporting user agents for algoliasearch >= 3.33.0.

@francoischalifour francoischalifour requested review from nunomaduro and a team January 22, 2020 16:55
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 88.971% when pulling e43fd80 on fix/user-agent-algoliasearch into 652bde4 on master.

Haroenv
Haroenv approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s still other things that could be in the number like “beta”, but since the whole source will stop working with v4, it seems fine to me

@francoischalifour
Copy link
Member Author

@Haroenv This PR fixes simple user agents that used to be supported. Other tags than latest were never supported here.

@francoischalifour francoischalifour merged commit 2f32ffb into master Jan 23, 2020
@francoischalifour francoischalifour deleted the fix/user-agent-algoliasearch branch January 23, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Agent is not being set
4 participants
@francoischalifour @coveralls @nunomaduro @Haroenv