This repository was archived by the owner on Dec 16, 2022. It is now read-only.
fix: templates without facets #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
approved these changes
Jun 7, 2018
Contributor
francoischalifour
left a comment
francoischalifour
left a comment
There was a problem hiding this comment.
Thank you! I'm gonna update the CSS too because it breaks the grid system when there's no .filters.
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
…ntsearch-app#38) * fix(Angular): don't generate an empty div without facets * fix(React): don't generate an empty div without facets * fix(Vue): don't generate an empty div without facets * chore: ignore vscode workspace configuration * fix(vanilla): don't generate an empty div without facets * feat(angular): Use flexbox display * feat(react): Use flexbox display * feat(vue): Use flexbox display * test(e2e): Update snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we don't provide any
attributesForFacetingthe templates generate an emptydiv.This PR remove this
divwhen no facets are provided.