This repository was archived by the owner on Dec 16, 2022. It is now read-only.
feat(templates): add React Native templates #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouss
force-pushed
the
feat/react-native
branch
from
7e52900 to
8ba560e
Compare
francoischalifour
approved these changes
Jun 14, 2018
Contributor
francoischalifour
left a comment
francoischalifour
left a comment
There was a problem hiding this comment.
That's great, thank you for this!
Contributor
|
One thing to note is that although this template will be released in the Could we offer a similar experience with React Native? With Expo? |
Contributor
|
seems like it's possible: https://forums.expo.io/t/modules-available-in-snack/1651/16 |
Contributor
|
Can it be loaded from a GitHub URL? |
Contributor
|
looking for that option now (asked on twitter) edit: quickly made sure it worked in snack: https://snack.expo.io/B1RIWR1ZQ, not sure yet how to load from url |
Contributor
Author
|
Yes it would be nice but at least the template is available from the CLI. |
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a "React InstantSearch Native" template that use
react-instantsearch-native.attributesForFacettingit's a bit hard to implement because there is a lots of condition. The code is a bit more complicated than the web in order to have a RefinementListmainAttributetheHighlightfile is generated but unused