This repository was archived by the owner on Dec 16, 2022. It is now read-only.
feat(templates): Add iOS template #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouss
reviewed
Jul 2, 2018
package.json
Outdated
| "scripts": { | ||
| "start": "node src/cli/index.js", | ||
| "test": "jest ./src", | ||
| "test:e2e:installs": "jest './scripts/e2e-installs.test.js'", |
Contributor
There was a problem hiding this comment.
Is there a reason to use single quotes rather than nothing?
Contributor
Author
There was a problem hiding this comment.
I can remove them, it works without quotes now. I think it used to get processed as a regex before and couldn't find the files.
packages/tasks/ios/install.js
Outdated
| @@ -0,0 +1,43 @@ | |||
| const process = require('process'); | |||
Contributor
There was a problem hiding this comment.
Why this file is in packages/... rather than src/tasks/... ?
Contributor
Author
There was a problem hiding this comment.
You're right, this folder shouldn't be there anymore (rebased from the old architecture).
packages/tasks/ios/install.js
Outdated
| @@ -0,0 +1,43 @@ | |||
| const process = require('process'); | |||
Contributor
There was a problem hiding this comment.
Does this file is really used? Seems that we do the same logic in the template's tasks?
Contributor
Author
There was a problem hiding this comment.
Indeed, I'll reuse the tasks in .template.js.
samouss
approved these changes
Jul 2, 2018
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
* feat(tasks): Support iOS * feat(template): Add iOS template * feat(template): Update iOS template * test(snapshots): Update iOS snapshots * chore(scripts): Add e2e installs script * test(installs): Test installation with Cocoapods * build(travis): Install CocoaPods * feat: Allow `libraryName` omission in templates * chore(scripts): Remove unnecessary quotes in Jest scripts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the InstantSearch iOS template using CocoaPods.
I made
libraryNamein.template.jsoptional as well in this PR (until algolia/instantsearch#5198 is implemented as dependency strategy).This way, the InstantSearch version is not asked in the CLI.
Preview