-
Notifications
You must be signed in to change notification settings - Fork 28
refactor(templates): use Vue CLI for 2.x.x #402
Conversation
5c6fdb9 to
ac350c3
Compare
Haroenv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works as expected
francoischalifour
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been meaning to update this template for a while. Thanks for tackling it!
The app is terribly lagging on my machine. Are you experiencing the same thing?
Why did you remove manifest.json?
I would be in favor of also updating the Vue InstantSearch v2 template to have the same setup and to reduce Renovate noise.
|
manifest.json is removed because Vue CLI no longer generates it I think |
Nope, I've also uploaded it to CodeSandbox and I don't have the issue.
Yep @Haroenv is correct, it's only generated with the PWA plugin enabled.
|
francoischalifour
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the template again this morning and it seems to work better than yesterday. Probably my machine's fault.
|
We can update the Vue InstantSearch v1 template in another PR. |
Haroenv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
30cf982 to
8ff4323
Compare
…rch-app#402) * refactor(templates): use Vue CLI * fix(templates): use port 3000 for Vue * update name in noscript
This PR updates the template for Vue InstantSearch 2.x.x with Vue CLI.
I've update the
.eslintrc.jsto disable two rules that conflict each other (until we fix the Algolia one):prettier/vuevue/component-name-in-template-casing