Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Conversation

@samouss
Copy link
Contributor

@samouss samouss commented Apr 18, 2019

This PR updates the template for Vue InstantSearch 2.x.x with Vue CLI.

I've update the .eslintrc.js to disable two rules that conflict each other (until we fix the Algolia one):

  • extends from prettier/vue
  • use kebab-case for vue/component-name-in-template-casing

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works as expected

Copy link
Contributor

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to update this template for a while. Thanks for tackling it!

The app is terribly lagging on my machine. Are you experiencing the same thing?

Why did you remove manifest.json?

I would be in favor of also updating the Vue InstantSearch v2 template to have the same setup and to reduce Renovate noise.

@Haroenv
Copy link
Contributor

Haroenv commented Apr 18, 2019

manifest.json is removed because Vue CLI no longer generates it I think

@samouss
Copy link
Contributor Author

samouss commented Apr 18, 2019

The app is terribly lagging on my machine. Are you experiencing the same thing?

Nope, I've also uploaded it to CodeSandbox and I don't have the issue.

Why did you remove manifest.json?

Yep @Haroenv is correct, it's only generated with the PWA plugin enabled.

https://cli.vuejs.org/guide/html-and-static-assets.html#the-index-file

Copy link
Contributor

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the template again this morning and it seems to work better than yesterday. Probably my machine's fault.

@francoischalifour
Copy link
Contributor

francoischalifour commented Apr 19, 2019

We can update the Vue InstantSearch v1 template in another PR.

@samouss samouss changed the title refactor(templates): use Vue CLI refactor(templates): use Vue CLI for 2.x.x Apr 19, 2019
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@francoischalifour
Copy link
Contributor

Good call on 1e64733 @Haroenv 👍

@samouss samouss merged commit 4a14b81 into master Apr 19, 2019
@samouss samouss deleted the refactor/vue-cli branch April 19, 2019 12:12
aymeric-giraudet pushed a commit to algolia/instantsearch that referenced this pull request Dec 14, 2022
…rch-app#402)

* refactor(templates): use Vue CLI

* fix(templates): use port 3000 for Vue

* update name in noscript
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants