This repository was archived by the owner on Dec 16, 2022. It is now read-only.
fix(templates): prepare InstantSearch template for v4 #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Haroenv
suggested changes
Oct 1, 2019
samouss
reviewed
Oct 1, 2019
Haroenv
approved these changes
Oct 1, 2019
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
solves the issue & still clean!
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the InstantSearch.js 3 template with a newer syntax that we recommend for InstantSearch.js 4.
This has the benefits of also working with v4, and therefore we won't need to create another template.