Skip to content

fix(Facet): avoid to unmount the RefinementList when no results from SFFV #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Haroenv merged 1 commit into from
Jul 11, 2018
Merged

fix(Facet): avoid to unmount the RefinementList when no results from SFFV #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion demos/react/ecommerce/src/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,8 @@ a {
margin-bottom: 16px;
}

.ais-RefinementList-item {
.ais-RefinementList-item,
.ais-RefinementList-noResults {
padding: 8px 16px;
}

Expand Down
8 changes: 4 additions & 4 deletions demos/react/ecommerce/src/Facet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React from "react";
import { RefinementList } from "react-instantsearch-dom";
import { connectRefinementList } from "react-instantsearch/connectors";
import { RefinementList, connectRefinementList } from "react-instantsearch-dom";

export default connectRefinementList(
({ translations, searchable, attribute, items }) =>
items.length && items.length > 0 ? (
({ translations, searchable, attribute, items, isFromSearch }) =>
isFromSearch || (items.length && items.length > 0) ? (
<RefinementList
attribute={attribute}
searchable={searchable}
Expand Down