New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SearchBox): Safari can only have <use> with xlinkHref #1970

Merged
merged 1 commit into from Feb 12, 2017

Conversation

Projects
None yet
2 participants
@Haroenv
Copy link
Member

Haroenv commented Feb 11, 2017

What project are you opening a pull request for?

  • react-instantsearch (use v2 base)

Summary

Safari can’t have with href, it needs xlink:href. Relevant MDN

Result

Since React 0.14 it's allowed to use all svg features, and thus also those that are usuallly written
with a colon.

closes #1968

before after
screen shot 2017-02-11 at 14 49 51 screen shot 2017-02-11 at 14 49 58
@vvo

This comment has been minimized.

Copy link
Member

vvo commented Feb 11, 2017

Is xmlsXlink required?

fix(SearchBox): Safari can only have <use> with xlinkHref
Since React 0.14 it's allowed to use all svg features, and thus also those that are usuallly written
with a colon.

closes #1968

@Haroenv Haroenv force-pushed the fix/svg-xlinkHref branch from 97fbac4 to 18f90ee Feb 11, 2017

@Haroenv

This comment has been minimized.

Copy link
Member Author

Haroenv commented Feb 11, 2017

You’re right @vvo, the xmlnsXlink is not necessary, just tested and updated the PR.

@vvo

This comment has been minimized.

Copy link
Member

vvo commented Feb 12, 2017

Nice

@vvo vvo merged commit 7ab00bd into v2 Feb 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@vvo vvo deleted the fix/svg-xlinkHref branch Feb 12, 2017

vvo added a commit that referenced this pull request Feb 15, 2017

v3.2.0
<a name="3.2.0"></a>
# [3.2.0](v3.1.0...v3.2.0) (2017-02-15)

### Bug Fixes

* **Configure:** use props a unique source of truth (#1967) ([9d53d86](9d53d86))
* **SearchBox:** Safari can only have <use> with xlinkHref (#1970) ([7ab00bd](7ab00bd)), closes [#1968](#1968)

### Features

* **MultiRange:** add an all range (#1959) ([a3dc950](a3dc950))

### BREAKING CHANGES

* MultiRange: - MultiRange/connectMultiRange: will add a "All" range to allow unselection of range without the usage of CurrentRefinements. This range can be either filtered or ramove via CSS if not needed. The label can be changed by using our translations system.

Haroenv added a commit to Haroenv/instantsearch-demo-debounce that referenced this pull request Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment