New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): Conditional display code sample #1974

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Projects
None yet
2 participants
@Haroenv
Copy link
Member

Haroenv commented Feb 13, 2017

What project are you opening a pull request for?

  • react-instantsearch (use v2 base)

Summary

The sentence "no results has been found" sounds a bit weird, I simplified it

Result

The sentence is now "No results found for {query}".

@bobylito
Copy link
Contributor

bobylito left a comment

Nicer! :D

@bobylito bobylito merged commit 4609a13 into v2 Feb 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bobylito bobylito deleted the fix/typo-conditional branch Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment