New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): use 'translations' in SearchBox #1980

Merged
merged 1 commit into from Feb 15, 2017

Conversation

Projects
None yet
3 participants
@Haroenv
Copy link
Member

Haroenv commented Feb 14, 2017

What project are you opening a pull request for?

  • react-instantsearch (use v2 base)

Summary

It was kind of confusing to realise that the actual prop to add was an object with "translations" as name, since using "translate" would cause "object is not a function" errors.

I haven't yet checked if this is the case with all of the stories, or just this one.

Result

the story now shows "translations" as key

@vvo

This comment has been minimized.

Copy link
Member

vvo commented Feb 14, 2017

I haven't yet checked if this is the case with all of the stories, or just this one.

Can you check quickly so we do not have to get it back to this afterwards? Thanks!

docs(storybook): use 'translations' in SearchBox
It was kind of confusing to realise that the actual prop to add was an object with "translations" as name, since using "translate" would cause "object is not a function" errors.

I haven't yet checked if this is the case with all of the stories, or just this one.

@Haroenv Haroenv force-pushed the fix/searchbox-translations branch from 9e382c0 to 39d7abd Feb 15, 2017

@Haroenv

This comment has been minimized.

Copy link
Member Author

Haroenv commented Feb 15, 2017

There were a few other components where "translation" was visible in the UI as "translate"; I've edited those in this commit.

@Haroenv Haroenv added the RangeSlider label Feb 15, 2017

@vvo

This comment has been minimized.

Copy link
Member

vvo commented Feb 15, 2017

Thanks a lot :)

@vvo vvo merged commit 3b205ce into v2 Feb 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@Haroenv Haroenv deleted the fix/searchbox-translations branch Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment