New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): how to style svgs #1982

Merged
merged 2 commits into from Feb 15, 2017

Conversation

Projects
None yet
2 participants
@Haroenv
Copy link
Member

Haroenv commented Feb 15, 2017

What project are you opening a pull request for?

  • react-instantsearch (use v2 base)

Summary

it's not so hard, but the actual svg elements don't have a class, so you will have to target them explicitly.

SVG elements also have a different feature set, so this example should clear things up.

Result

Extra piece of text in the Styling widgets part that explains briefly that we work with svg, so it's styleable and how.

see #1981

docs(guide): how to style svgs
it's not so hard, but the actual svg elements don't have a class, so you will have to target them explicitly.

SVG elements also have a different feature set, so this example should clear things up.

@Haroenv Haroenv force-pushed the doc/how-to-style-svg branch from 87cb952 to 5797aa7 Feb 15, 2017

@vvo

This comment has been minimized.

Copy link
Member

vvo commented Feb 15, 2017

Thx, documentation is key!

@vvo vvo merged commit de91634 into v2 Feb 15, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details

@vvo vvo deleted the doc/how-to-style-svg branch Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment