Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Feat/mobile improvements #1999
What project are you opening a pull request for?
There are some things that can be better in a searchbox by default. Since I enabled those in yarn search, I should move them upstream too.
mthuret left a comment
Do you know why we need to put action="" to get the button "search" on iOS? Why the "type=search" isn't enough? Although what is the behaviour on android?
Although don't forget to update the snapshots ;)
On Android it looks like this, so autosuggest is not disabled, but the return symbol is a search icon. Of course this is very fragmented, so won't be the same everywhere.
(sorry for the non-screenshot, it didn't want to upload)
Input type search alone (so this or wasn't needed on android) already shows the icon
added this to Doing (Remove from project when done)
in InstantSearch - DEPRECATED (kept for reference, to delete in may)
Feb 22, 2017
The way I deal with it is: are any of those commits self sufficient or are they interdependent and only make sense when all together? If none of the commits are providing a "good enough" state then I prefer to have them all in one and label it as
Because from a CHANGELOG POV it makes more sense than having to read three different commits and infer the ultimate impact on my UI.
Ultimately I would even add a code comment next to action="" because that's a "WTF" moment: there's no way from reading the code to understand why it's here. So adding a comment with a reference to either documentation or a good stackoverflow post is always good.