New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SearchBox) add role=search to the form #2046

Merged
merged 1 commit into from Mar 15, 2017

Conversation

Projects
None yet
3 participants
@Haroenv
Copy link
Member

Haroenv commented Mar 13, 2017

What project are you opening a pull request for?

  • react-instantsearch (use v2 base)

Summary

Add a role=search to the form of the searchbox.

This helps for screenreaders, and is valid html5 since december 2015. Before then it was working, but not valid. see also w3c/html-aria#18

Result

Some screen readers will read our search input as search form: 3 inputs. Others will still say form: 3 inputs.

feat(SearchBox) add role=search to the form
This helps for screenreaders, and is valid html5 since december 2015. Before then it was working, but not valid. see also w3c/html-aria#18
@iam4x

iam4x approved these changes Mar 13, 2017

@vvo vvo merged commit d1e90f3 into v2 Mar 15, 2017

1 check passed

deploy/netlify Deploy preview ready!
Details

@vvo vvo deleted the feat/searchbox-role-search branch Mar 15, 2017

Haroenv added a commit that referenced this pull request Mar 20, 2017

v3.2.2-beta0
<a name="3.2.2-beta0"></a>
## [3.2.2-beta0](v3.2.1...v3.2.2-beta0) (2017-03-20)

### Bug Fixes

* **InfiniteHits:** provide translation key for `Load More` (#2048) ([6130bf2](6130bf2))
* **SearchBox:** better mobile behaviour by default ([ea968b3](ea968b3))
* **example:** link to instantsearch/react (#2007) ([5e674cd](5e674cd))
* **recipes:** react router v4 ([de673bf](de673bf))

### Features

* **SearchBox:** add role=search to the form (#2046) ([d1e90f3](d1e90f3))
* **SearchBox:** allow custom reset and submit components (#1991) ([cd303d7](cd303d7))
* **searchBox:** add event handling ([e267ab6](e267ab6)), closes [#2017](#2017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment