From 643aaa4f6c7f21cfc2d3c873cd558e4003b9ce38 Mon Sep 17 00:00:00 2001 From: Haroen Viaene Date: Tue, 6 Aug 2019 14:17:11 +0200 Subject: [PATCH] fix(lint): correct setup to require extension Apparently the "ignorePackages" option also ignores some relative imports, where it shouldn't. The flag however works as expected. --- .eslintrc.js | 2 +- src/__tests__/changelog.test.js | 2 +- src/__tests__/config.test.js | 2 +- src/__tests__/formatPkg.test.js | 4 ++-- src/__tests__/typescript.test.js | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index ca89e71ea..98db63fc7 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -2,6 +2,6 @@ module.exports = { extends: ['algolia', 'algolia/jest'], rules: { 'valid-jsdoc': 'off', - 'import/extensions': ['error', 'ignorePackages'], + 'import/extensions': ['error', 'always', { ignorePackages: true }], }, }; diff --git a/src/__tests__/changelog.test.js b/src/__tests__/changelog.test.js index 43098d0e4..ea10513d7 100644 --- a/src/__tests__/changelog.test.js +++ b/src/__tests__/changelog.test.js @@ -1,4 +1,4 @@ -import { getChangelogs, __RewireAPI__ } from '../changelog'; // eslint-disable-line import/named +import { getChangelogs, __RewireAPI__ } from '../changelog.js'; // eslint-disable-line import/named const gotSnapshotUrls = new Set([ 'https://gitlab.com/janslow/gitlab-fetch/raw/master/CHANGELOG.md', diff --git a/src/__tests__/config.test.js b/src/__tests__/config.test.js index 6feaf3545..01b2c887c 100644 --- a/src/__tests__/config.test.js +++ b/src/__tests__/config.test.js @@ -1,4 +1,4 @@ -import config from '../config'; +import config from '../config.js'; it('gets the correct keys from env variables', () => { // from mocked .env diff --git a/src/__tests__/formatPkg.test.js b/src/__tests__/formatPkg.test.js index aa77f9256..5395ef209 100644 --- a/src/__tests__/formatPkg.test.js +++ b/src/__tests__/formatPkg.test.js @@ -1,6 +1,6 @@ -import formatPkg from '../formatPkg'; +import formatPkg from '../formatPkg.js'; import rawPackages from './rawPackages.json'; -import isISO8601 from 'validator/lib/isISO8601'; +import isISO8601 from 'validator/lib/isISO8601.js'; it('transforms correctly', () => { rawPackages diff --git a/src/__tests__/typescript.test.js b/src/__tests__/typescript.test.js index 9b839a342..c8b5558cc 100644 --- a/src/__tests__/typescript.test.js +++ b/src/__tests__/typescript.test.js @@ -1,6 +1,6 @@ -import { getTypeScriptSupport } from '../typescriptSupport'; jest.mock('../npm'); jest.mock('../unpkg'); +import { getTypeScriptSupport } from '../typescriptSupport.js'; import * as npm from '../npm/index.js'; import { fileExistsInUnpkg } from '../unpkg.js';