New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatPkg): rewrite get info into separate functions #39

Merged
merged 2 commits into from Apr 29, 2017

Conversation

Projects
None yet
2 participants
@Haroenv
Copy link
Member

Haroenv commented Apr 29, 2017

The complexity of this function was too high according to eslint, so it wouldn't regularly let me commit.

I broke all of the reassignments up into separate functions returning different versions.

Haroenv added some commits Apr 29, 2017

fix(formatPkg): rewrite get info into separate functions
The complexity of this funciton was too high according to eslint, so it wouldn't regularly let me commit. I broke all of the reassignments up into separate functions returning different versions.

@Haroenv Haroenv merged commit f0c3b27 into master Apr 29, 2017

@Haroenv Haroenv deleted the fix/lower-complexity-formatPkg branch Apr 29, 2017

@vvo

This comment has been minimized.

Copy link
Member

vvo commented May 9, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment