New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectAutocomplete can’t work if you’re in a single-index context #74

Closed
Haroenv opened this Issue Apr 30, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@Haroenv
Copy link
Member

Haroenv commented Apr 30, 2017

Do you want to request a feature or report a bug?

bug

Bug: What is the current behavior?

connectAutocomplete assumes that there are multiple indices, and this iterates over all of the keys to aggregate the hits

Bug: What is the expected behavior?

it should only do that if we’re in a multi-index context

Haroenv added a commit that referenced this issue Apr 30, 2017

Haroenv added a commit that referenced this issue Apr 30, 2017

@mthuret mthuret closed this in #75 May 2, 2017

mthuret added a commit that referenced this issue May 2, 2017

fix(connectAutoComplete): allow usage with hits from a single index (#75
)

* fix(connectAutoComplete): allow usage with hits from a single index

fixes #74

* fix(connectAutoComplete): use single/multi index API

* fix eslint

mthuret added a commit that referenced this issue May 2, 2017

v4.0.0-beta.5
<a name="4.0.0-beta.5"></a>
# [4.0.0-beta.5](v4.0.0-beta.4...v4.0.0-beta.5) (2017-05-02)

### Bug Fixes

* **connectAutoComplete:** allow usage with hits from a single index (#75) ([8b3b358](8b3b358)), closes [#74](#74)
* **InstantSearch:** update algoliaClient when it change (#70) ([9e97dbd](9e97dbd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment