Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in GitHubAction config #928

Merged
merged 1 commit into from Sep 28, 2020

Conversation

@donghoon-song
Copy link
Contributor

@donghoon-song donghoon-song commented Sep 26, 2020

NODE_AUTH_TOKEN is not used anywhere. And before fixing it, github action couldn't find NPM_AUTH_TOKEN from secrets so there was an issue publishing next npm package.

@eunjae-lee
Copy link
Collaborator

@eunjae-lee eunjae-lee commented Sep 28, 2020

@Donghoon759 Thanks for the PR!
Can I ask you to try the updated GitHub config with your repo if it's possible?

@donghoon-song
Copy link
Contributor Author

@donghoon-song donghoon-song commented Sep 28, 2020

@Donghoon759 Thanks for the PR!
Can I ask you to try the updated GitHub config with your repo if it's possible?

@eunjae-lee
I faced that issue before changing config. I solved that issue by changing the config as I described. If you have more questions or something you need, feel free to ask me. Thanks for reading :)

image
image

@eunjae-lee eunjae-lee merged commit 489647d into algolia:main Sep 28, 2020
1 check passed
1 check passed
Semantic Pull Request ready to be squashed
Details
@eunjae-lee
Copy link
Collaborator

@eunjae-lee eunjae-lee commented Sep 28, 2020

@Donghoon759

Thanks for the test results.
feel free to open another PR to add yourself as a contributor!

yarn contributors:add <user-name> code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.