Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated indexer.md with new Java code samples, updated examples/indexer/java code samples, atomic transfer graphic fix #424

Merged
merged 4 commits into from Jun 15, 2021
Merged

Updated indexer.md with new Java code samples, updated examples/indexer/java code samples, atomic transfer graphic fix #424

merged 4 commits into from Jun 15, 2021

Conversation

iskysun96
Copy link
Collaborator

@iskysun96 iskysun96 commented Jun 10, 2021 •
edited

The Java codes for indexer were outdated due to syntax changes.

@iskysun96 iskysun96 marked this pull request as draft June 10, 2021 18:20
@iskysun96 iskysun96 marked this pull request as ready for review June 10, 2021 18:21
ryanRfox
ryanRfox suggested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@ryanRfox ryanRfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the error handling. Just a couple of changes needed.

examples/indexer/java/AccountInfo.java Outdated Show resolved Hide resolved
examples/indexer/java/LookupApplication.java Show resolved Hide resolved
examples/indexer/java/SearchTransactionsNote.java Show resolved Hide resolved
rfustino
rfustino reviewed Jun 14, 2021
View reviewed changes
Copy link
Contributor

@rfustino rfustino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not cause problems and works as is. Sometimes a L is needed if too long.

examples/indexer/java/LookupApplication.java Show resolved Hide resolved
@iskysun96
Copy link
Collaborator Author

iskysun96 commented Jun 14, 2021 •
edited

@ryanRfox Requested fixes are edited and pushed!

@iskysun96
Copy link
Collaborator Author

Atomic Transfer graphic at https://developer.algorand.org/docs/build-apps/apps/ was incorrect.
Updated the graphic.

@iskysun96 iskysun96 changed the title Updated indexer.md with new Java code samples, updated examples/indexer/java code samples Updated indexer.md with new Java code samples, updated examples/indexer/java code samples, atomic transfer graphic fix Jun 15, 2021
@ryanRfox ryanRfox merged commit c7ae899 into algorandfoundation:staging Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfustino rfustino rfustino left review comments

@ryanRfox ryanRfox ryanRfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Atomic Transfers Graphic
3 participants
@iskysun96 @rfustino @ryanRfox