Skip to content

/go-algorand

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add goal report #299

Merged
merged 4 commits into from Sep 24, 2019

Conversation

@mjiang102628
Copy link
Contributor

mjiang102628 commented Sep 9, 2019

  • add goal -v
  • goal report includes output of goal -v, uname -a, genesisID, and goal node status
mjiang102628 added 2 commits Sep 9, 2019
@mjiang102628
add goal report
Loading status checks…
e03856a 
- add goal -v
- goal report includes output of goal -v, uname -a, genesisID, and goal node status
@mjiang102628
add expect test for goal report
Loading status checks…
97449e9
@tsachiherman tsachiherman requested a review from rotemh Sep 10, 2019
@pzbitskiy
pzbitskiy reviewed Sep 10, 2019
View changes
cmd/goal/commands.go Outdated
if versionCheck {
version := config.GetCurrentVersion()
fmt.Printf("%d\n%s.%s [%s] (commit #%s)\n%s\n", version.AsUInt64(), version.String(),
version.Channel, version.Branch, version.GetCommitHash(), config.GetLicenseInfo())

This comment has been minimized.

Sign in to view
Copy link
@pzbitskiy

pzbitskiy Sep 10, 2019

Contributor

This version printing code repeats twice in this change set plus two more times in cmd/algo[h|d]/main.go. Makes sense to implement a lib function now.
@mjiang102628
create PrintVersionAndLicense()
Loading status checks…
43dfad4 
- remove duplicate code
@pzbitskiy
pzbitskiy reviewed Sep 10, 2019
View changes
Copy link
Contributor

pzbitskiy left a comment

Looks good to me
@tsachiherman
tsachiherman requested changes Sep 12, 2019
View changes
Copy link
Contributor

tsachiherman left a comment

I think that @pzbitskiy suggestion was good, but implementation has an issue -
We don't want to print to the console from any non-console applications.
Could you rename the function from PrintVersionAndLicense to FormatVersionAndLicense and perform the actual printing in the console application instead ?
@mjiang102628
change PrintVersionAndLicense to FormatVersionAndLicense
Loading status checks…
731bad1
@tsachiherman
tsachiherman approved these changes Sep 12, 2019
View changes
Copy link
Contributor

tsachiherman left a comment

Thanks for applying the changes; could you also get an ok from @rotemh as well ?
@rotemh
rotemh approved these changes Sep 16, 2019
View changes
@algoradam

This comment has been minimized.

Sign in to view
Copy link
Contributor

algoradam commented Sep 24, 2019

Is this PR waiting on something, or can we go ahead and merge it?
@mjiang102628

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

mjiang102628 commented Sep 24, 2019

Nope; it can be merged.
@algoradam algoradam merged commit b96587b into algorand:master Sep 24, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
@mjiang102628 mjiang102628 deleted the mjiang102628:goalreport branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzbitskiy pzbitskiy

@rotemh rotemh

@tsachiherman tsachiherman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@mjiang102628 @algoradam @rotemh @pzbitskiy @tsachiherman
You can’t perform that action at this time.