Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: update node exporter to ignore malformed metrics #4518

Merged
merged 1 commit into from Sep 8, 2022

Conversation

onetechnical
Copy link
Contributor

@onetechnical onetechnical commented Sep 8, 2022

Summary

Metrics with closing curly brace before open curly brace were breaking node exporter. This pulls in a patched node exporter.

Binaries built here:
https://github.com/algorand/node_exporter/actions/runs/3017995065

Test Plan

N/A

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #4518 (c7448e3) into master (dc2df6b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4518      +/-   ##
==========================================
- Coverage   55.26%   55.23%   -0.04%     
==========================================
  Files         398      398              
  Lines       50366    50366              
==========================================
- Hits        27836    27820      -16     
- Misses      20199    20209      +10     
- Partials     2331     2337       +6     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
crypto/merkletrie/node.go 90.69% <0.00%> (-2.80%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
ledger/tracker.go 71.91% <0.00%> (-2.13%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-1.73%) ⬇️
ledger/acctupdates.go 69.44% <0.00%> (-0.75%) ⬇️
network/wsPeer.go 68.11% <0.00%> (+0.27%) ⬆️
catchup/service.go 69.62% <0.00%> (+0.98%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants