Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txHandler: upgraded benchmarks #4834

Merged

Conversation

algonautshant
Copy link
Contributor

This PR upgrades the txHandler benchmark
New features:

  • Add setting incoming transaction rate
  • Add backlog worker with transaction dropping
  • Count dropped transactions

Run the benchmark with -benchtime=50000x to go over the buffer sizes in order to observe dropped transactions.
Transactions will likely be dropped when the TPS is higher than 600,000.
It needs studying if the signature failure rate impacts the performance/dropped rate.

- Add setting incoming transaction rate
- Add backlog worker with transaction dropping
- Count dropped transactions
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #4834 (466d250) into master (e8b1416) will decrease coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4834      +/-   ##
==========================================
- Coverage   53.40%   52.88%   -0.52%     
==========================================
  Files         422      422              
  Lines       53858    53859       +1     
==========================================
- Hits        28761    28483     -278     
- Misses      22797    23066     +269     
- Partials     2300     2310      +10     
Impacted Files Coverage Δ
util/metrics/counter.go 88.17% <100.00%> (+0.12%) ⬆️
tools/debug/logfilter/main.go 0.00% <0.00%> (-83.34%) ⬇️
network/msgOfInterest.go 75.00% <0.00%> (-25.00%) ⬇️
agreement/sort.go 76.19% <0.00%> (-23.81%) ⬇️
agreement/certificate.go 66.66% <0.00%> (-16.67%) ⬇️
daemon/algod/api/server/router.go 0.00% <0.00%> (-13.89%) ⬇️
cmd/tealdbg/cdtSession.go 54.83% <0.00%> (-11.99%) ⬇️
data/transactions/signedtxn.go 18.51% <0.00%> (-11.12%) ⬇️
util/db/dbutil.go 32.73% <0.00%> (-9.53%) ⬇️
protocol/codec.go 55.78% <0.00%> (-8.43%) ⬇️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

data/txHandler_test.go Show resolved Hide resolved
data/txHandler_test.go Outdated Show resolved Hide resolved
data/txHandler_test.go Outdated Show resolved Hide resolved
data/txHandler_test.go Outdated Show resolved Hide resolved
data/txHandler_test.go Outdated Show resolved Hide resolved
data/txHandler_test.go Show resolved Hide resolved
data/txHandler_test.go Outdated Show resolved Hide resolved
@algorandskiy algorandskiy merged commit 3abde76 into algorand:master Dec 1, 2022
@algorandskiy algorandskiy changed the title txHandler: Upgraded txHandler benchmark txHandler: upgraded benchmarks Dec 1, 2022
winder pushed a commit to winder/go-algorand that referenced this pull request Dec 2, 2022
* Add setting incoming transaction rate
* Add backlog worker with transaction dropping
* Count dropped transactions
algolucky pushed a commit to algolucky/go-algorand that referenced this pull request Dec 15, 2022
* Add setting incoming transaction rate
* Add backlog worker with transaction dropping
* Count dropped transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants