New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txHandler: upgraded benchmarks #4834
Merged
algorandskiy
merged 5 commits into
algorand:master
from
algonautshant:shant/txHandler_rate_bench
Dec 1, 2022
Merged
txHandler: upgraded benchmarks #4834
algorandskiy
merged 5 commits into
algorand:master
from
algonautshant:shant/txHandler_rate_bench
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add setting incoming transaction rate - Add backlog worker with transaction dropping - Count dropped transactions
Codecov Report
@@ Coverage Diff @@
## master #4834 +/- ##
==========================================
- Coverage 53.40% 52.88% -0.52%
==========================================
Files 422 422
Lines 53858 53859 +1
==========================================
- Hits 28761 28483 -278
- Misses 22797 23066 +269
- Partials 2300 2310 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
requested changes
Dec 1, 2022
AlgoAxel
reviewed
Dec 1, 2022
algorandskiy
approved these changes
Dec 1, 2022
algorandskiy
changed the title
txHandler: Upgraded txHandler benchmark
txHandler: upgraded benchmarks
Dec 1, 2022
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Dec 2, 2022
* Add setting incoming transaction rate * Add backlog worker with transaction dropping * Count dropped transactions
This was referenced Dec 9, 2022
algolucky
pushed a commit
to algolucky/go-algorand
that referenced
this pull request
Dec 15, 2022
* Add setting incoming transaction rate * Add backlog worker with transaction dropping * Count dropped transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the txHandler benchmark
New features:
Run the benchmark with -benchtime=50000x to go over the buffer sizes in order to observe dropped transactions.
Transactions will likely be dropped when the TPS is higher than 600,000.
It needs studying if the signature failure rate impacts the performance/dropped rate.