Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant liveness and duplicate checks in txHandler. #523

Merged
merged 2 commits into from Nov 15, 2019

Conversation

@derbear
Copy link
Collaborator

derbear commented Nov 14, 2019

As of the transaction pool refactor, transactionPool.Test already performs
duplicate detection and transaction liveness checks.

As of the transaction pool refactor, transactionPool.Test already performs
duplicate detection and transaction liveness checks.
@derbear derbear requested a review from tsachiherman Nov 14, 2019
Copy link
Contributor

tsachiherman left a comment

looks good to me.

@derbear derbear merged commit 1222702 into algorand:master Nov 15, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
@derbear derbear deleted the derbear:redundant-txhandler-dup branch Nov 15, 2019
winder added a commit that referenced this pull request Nov 15, 2019
As of the transaction pool refactor, transactionPool.Test already performs
duplicate detection and transaction liveness checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.