Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the docker file to work #53

Merged
merged 3 commits into from Jun 20, 2019

Conversation

@zacharyestep
Copy link
Contributor

zacharyestep commented Jun 19, 2019

Summary

Had some trouble running the dev setup scripts in the provided docker file environment. They rely on sudo. Made changes.

Test Plan

Run build && test

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jun 19, 2019

CLA assistant check
All committers have signed the CLA.

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@zacharyestep

This comment has been minimized.

Copy link
Contributor Author

zacharyestep commented Jun 19, 2019

(closing and reopening for travis rebuild)

Copy link
Contributor

Karmastic left a comment

If you want to fix the dockerfile, please keep this PR focused on that. Addressing the assumptions around GITHUBREPO is a larger change that I would like to consider separately. Your changes only address a fraction of the total scope.

@zacharyestep

This comment has been minimized.

Copy link
Contributor Author

zacharyestep commented Jun 20, 2019

If you want to fix the dockerfile, please keep this PR focused on that. Addressing the assumptions around GITHUBREPO is a larger change that I would like to consider separately. Your changes only address a fraction of the total scope.

Reduced scope as desired. Do you request further changes?

Copy link
Contributor

Karmastic left a comment

Thanks! This works. I'm going to encourage prioritizing support for agile source location - you are correct it is an undue burden requiring a specific root folder location.

@Karmastic Karmastic merged commit 1b642f4 into algorand:master Jun 20, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.