Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when consensus protocol is unknown to libgoal. #548

Merged
merged 2 commits into from Nov 20, 2019

Conversation

@derbear
Copy link
Collaborator

derbear commented Nov 19, 2019

No description provided.

@derbear derbear requested review from winder and tsachiherman Nov 19, 2019
proto, ok := config.Consensus[protocol.ConsensusCurrentVersion]
if !ok {
err = fmt.Errorf("Unknown consensus protocol %s", protocol.ConsensusCurrentVersion)
return
}

Comment on lines +217 to +222

This comment has been minimized.

Copy link
@tsachiherman

tsachiherman Nov 19, 2019

Contributor

I'm not really sure how this would happen. once the binary is already compiled, the config.Consensus should already have the entry for protocol.ConsensusCurrentVersion.

This comment has been minimized.

Copy link
@derbear

derbear Nov 19, 2019

Author Collaborator

Yeah. I thought about that as well. I put the check there anyway for consistency.

Copy link
Contributor

tsachiherman left a comment

LGTM

@derbear derbear merged commit eed4224 into algorand:master Nov 20, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
@derbear derbear deleted the derbear:libgoal-error-version branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.