Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOAL2-796] re-enable firstvalid and lastvalid for goal clerk #55

Merged
merged 13 commits into from Jun 20, 2019

Conversation

@EvanJRichard
Copy link
Contributor

EvanJRichard commented Jun 19, 2019

Summary

During the kmd/algod integration PR, goal clerk's --firstValid and --lastValid options were disabled. This PR proposes to re-enable these options.

Of note, no additional validation is provided to these options: the user is allowed to enter whatever --firstValid and --lastValid they wish. Both must be provided as nonzero args for the default behavior (use the current round, and that round+1000, as the validity period).

Test Plan

Used goal clerk send -out to generate txfiles before and after the change, and then goal clerk inspect to inspect them. Got expected output: before the change, txns were always valid from curRound to curRound+1000, after the change, the user can define these values.

…rks as it did before) and ConstructPaymentForRound (which is as ConstructPayment, but instead of being valid for curRound -> curRound+1000, it is valid for whatever passed rounds without validation)
@EvanJRichard EvanJRichard requested review from derbear and algoradam Jun 19, 2019
@EvanJRichard EvanJRichard self-assigned this Jun 19, 2019
cmd/goal/clerk.go Outdated Show resolved Hide resolved
cmd/goal/clerk.go Outdated Show resolved Hide resolved
libgoal/libgoal.go Outdated Show resolved Hide resolved
cmd/goal/clerk.go Outdated Show resolved Hide resolved
libgoal/libgoal.go Outdated Show resolved Hide resolved
libgoal/libgoal.go Outdated Show resolved Hide resolved
@EvanJRichard EvanJRichard requested review from derbear and zeldovich Jun 19, 2019
cmd/goal/clerk.go Outdated Show resolved Hide resolved
libgoal/unencryptedWallet.go Outdated Show resolved Hide resolved
libgoal/unencryptedWallet.go Outdated Show resolved Hide resolved
@EvanJRichard EvanJRichard requested a review from zeldovich Jun 19, 2019
@EvanJRichard EvanJRichard dismissed derbear’s stale review Jun 19, 2019

dismissing stale/addressed review

@zeldovich zeldovich merged commit ece2bbb into algorand:master Jun 20, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.