Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry Tweaks #572

Merged
merged 11 commits into from Dec 4, 2019
Merged

Telemetry Tweaks #572

merged 11 commits into from Dec 4, 2019

Conversation

@winder
Copy link
Member

winder commented Dec 2, 2019

This event has generally caused more harm than good. Disable it for now.

@winder winder requested a review from tsachiherman Dec 2, 2019
Copy link
Contributor

tsachiherman left a comment

I'm not opposing to disabling the log field, but it doesn't look the best way to implement it.
The existing code also has a bug where it wouldn't pass the 'session' when adding the log field.
How about passing a different value to reportLogLevel via newTelemetryFilteredHook so that this code would not get invoked ?

@winder winder changed the title Turn off log history event. Telemetry Tweaks Dec 3, 2019
catchup/service.go Outdated Show resolved Hide resolved
@winder winder requested a review from tsachiherman Dec 3, 2019
// Stop retrying after a while.
if i > 20 {
s.log.Errorf("fetchAndWrite(%v): failed to fetch block many times", )
return false
}

Comment on lines 171 to 176

This comment has been minimized.

Copy link
@tsachiherman

tsachiherman Dec 3, 2019

Contributor

I don't think that we want that, as it competes with the existing catchup logic.

This comment has been minimized.

Copy link
@winder

winder Dec 4, 2019

Author Member

Is there a number between 20 and 6 million that you think would be alright?

fetchAndWrite(3317176): block contents do not match header (attempt 6242741)

This comment has been minimized.

Copy link
@tsachiherman

tsachiherman Dec 4, 2019

Contributor

yes; we want to have a number that is greater than the number of relays so that every relay is likely to be attempted before giving up.

catchup/service.go Outdated Show resolved Hide resolved
logging/telemetry.go Outdated Show resolved Hide resolved
winder added 2 commits Dec 4, 2019
@winder winder requested a review from tsachiherman Dec 4, 2019
@tsachiherman tsachiherman merged commit 46c6e53 into algorand:master Dec 4, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
pzbitskiy added a commit to pzbitskiy/go-algorand that referenced this pull request Dec 20, 2019
* Turn off log history event.

* Make catchup less verbose when a future protocol version is detected.

* Make telemetryURIUpdateService less verbose.

* Use smaller log history instead of disabling it.

* Disconnect with peer during catchup if block header is from a future protocol version.

* Fix nits

* Stop trying after a while.

* Hard code small log history depth.

* Fix dumb mistakes.

* Increase catchup retry limit.

* Return detailed error string in ReadFromSRV instead of logging a warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.