Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-driven utility for automatic relay configuration #66

Merged
merged 7 commits into from Jun 24, 2019

Conversation

@Karmastic
Copy link
Contributor

Karmastic commented Jun 20, 2019

This adds a tool algorelay that is used for checking and updating Relay configurations in DNS based on our process for mainnet. The tool works against a JSON input file providing details about relays that should be configured, and details about their configuration.
For production, this is paired with the foundation's afdb1 relay command.

David Shoots and others added 6 commits Jun 15, 2019
David Shoots
David Shoots
Remove extra fields from Relay, dead code, and add copyright headers.
@Karmastic Karmastic requested a review from tsachiherman Jun 20, 2019
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jun 20, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

Karmastic
David Shoots


David Shoots seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

tsachiherman left a comment

looks good, one comment -
we. need to get rid of the zoneid; we should use the email/authkey + domainArgs to discover it dynamically and use it.
A misconfigured mismatch between the zoneid and domainArgs would Create a sub-domain under the zoneid, which is not what we want.

The functionality to extract the zoneid from the email/keyauth is already used in algons.

@Karmastic

This comment has been minimized.

Copy link
Contributor Author

Karmastic commented Jun 22, 2019

looks good, one comment -
we. need to get rid of the zoneid; we should use the email/authkey + domainArgs to discover it dynamically and use it.
A misconfigured mismatch between the zoneid and domainArgs would Create a sub-domain under the zoneid, which is not what we want.

The functionality to extract the zoneid from the email/keyauth is already used in algons.

Can you make those change in this PR?

@Karmastic Karmastic merged commit 5ad68d2 into master Jun 24, 2019
2 of 3 checks passed
2 of 3 checks passed
license/cla Contributor License Agreement is not signed yet.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@Karmastic Karmastic deleted the david/ebRelays branch Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.