Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bash and zsh completion support #82

Merged
merged 2 commits into from Jun 25, 2019

Conversation

@zeldovich
Copy link
Contributor

zeldovich commented Jun 24, 2019

as suggested in #80

as suggested in #80
@zeldovich zeldovich force-pushed the zeldovich:bash branch from 0afcf57 to 6b4b59e Jun 24, 2019
@derbear derbear requested a review from rotemh Jun 24, 2019
@rotemh

This comment has been minimized.

Copy link
Collaborator

rotemh commented Jun 25, 2019

Looks good. One thing - since it's a fairly trivial addition for the sake of completion - Can we also add zsh completions? Cobra supports it as well.

@zeldovich zeldovich changed the title add bash completion support add bash and zsh completion support Jun 25, 2019
@rotemh
rotemh approved these changes Jun 25, 2019
@zeldovich zeldovich merged commit 4218134 into algorand:master Jun 25, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
@zeldovich zeldovich deleted the zeldovich:bash branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.